On Wed, 2013-01-09 at 10:26 +0530, Vasanthakumar Thiagarajan wrote: > +/** > + * enum nl80211_acl_policy_attr - The access control policy which needs to be > + * applied on a MAC list set by %NL80211_CMD_START_AP and > + * %NL80211_CMD_SET_MAC_ACL. To be used with %NL80211_ATTR_ACL_POLICY. This is not valid kernel-doc, the short description must fit on the line and you can have extra description later. > + if (WARN_ON((wiphy->max_acl_mac_addrs) && extra parentheses? > +/* This function returns an error or the number of nested attributes */ > +static int validate_acl_mac_addrs(struct nlattr *nl_attr) > +{ > + struct nlattr *attr; > + int n_entries = 0, tmp; > + > + nla_for_each_nested(attr, nl_attr, tmp) { > + if (nla_len(attr) != ETH_ALEN) > + return -EINVAL; > + > + if (!is_valid_ether_addr(nla_data(attr))) > + return -EINVAL; Does that make sense? If somebody wants to fill the list with invalid addresses, maybe they should be able to? especially if it's a blacklist and the client is, for some reason, already using an invalid address? > +/* > + * This function parses ACL information and allocates memory for ACL data. > + * On successful return, the calling function is responsible to free the > + * ACL buffer returned by this function. > + */ > +static int parse_acl_data(struct wiphy *wiphy, struct genl_info *info, > + struct cfg80211_acl_data **acl) Please use ERR_PTR() and family and return the structure. > + err = rdev->ops->set_mac_acl(&rdev->wiphy, dev, acl); tracing please. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html