On 2013-01-14 8:58 PM, John W. Linville wrote: > On Sun, Jan 13, 2013 at 07:54:58PM +0100, Felix Fietkau wrote: >> ar900*_init_mode_regs needs to be called before RF banks are allocated, >> otherwise the storage size of RF banks isn't known. This patch fixes >> a memory overrun that can show up as a crash on unloading the module. >> >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> > > <snip> > >> @@ -410,7 +411,10 @@ int ar9002_hw_attach_ops(struct ath_hw *ah) >> struct ath_hw_ops *ops = ath9k_hw_ops(ah); >> int ret; >> >> - priv_ops->init_mode_regs = ar9002_hw_init_mode_regs; >> + ret = ar9002_hw_init_mode_regs(ah); >> + if (ret) >> + return ret; >> + >> priv_ops->init_mode_gain_regs = ar9002_hw_init_mode_gain_regs; >> >> ops->config_pci_powersave = ar9002_hw_configpcipowersave; > > This hunk depends on "ath9k_hw: use the devres API for allocations", > which is queue for 3.9. Can you revise this for 3.8? If not, should > I hold just this one for 3.9? Or the earlier patch in the series > as well? Oh, I got the version mixed up, put this into 3.9 then, 3.8 doesn't need it. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
