Search Linux Wireless

Re: [PATCH] wireless: make the reg_notifier() void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-01-11 at 18:39 +0000, mcgrof@xxxxxxxxxxxxxxxx wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
> 
> The reg_notifier()'s return value need not be checked
> as it is only supposed to do post regulatory work and
> that should never fail. Any behaviour to regulatory
> that needs to be considered before cfg80211 does work
> to a driver should be specified by using the already
> existing flags, the reg_notifier() just does post
> processing should it find it needs to.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx>
> ---

For the wlcore part:

> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
> index d7de063..ce6e62a 100644
> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -89,8 +89,8 @@ static int wl12xx_set_authorized(struct wl1271 *wl,
>  	return 0;
>  }
>  
> -static int wl1271_reg_notify(struct wiphy *wiphy,
> -			     struct regulatory_request *request)
> +static void wl1271_reg_notify(struct wiphy *wiphy,
> +			      struct regulatory_request *request)
>  {
>  	struct ieee80211_supported_band *band;
>  	struct ieee80211_channel *ch;
> @@ -107,8 +107,6 @@ static int wl1271_reg_notify(struct wiphy *wiphy,
>  				     IEEE80211_CHAN_PASSIVE_SCAN;
>  
>  	}
> -
> -	return 0;
>  }
>  
>  static int wl1271_set_rx_streaming(struct wl1271 *wl, struct wl12xx_vif *wlvif,

Acked-by: Luciano Coelho <coelho@xxxxxx>

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux