Search Linux Wireless

Re: [PATCH] ath9k_htc: Fix memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry Finger wrote:
> Yes, your fix handles the normal case, and you can add a
> Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Thanks.

> I still have one remaining question. It is possible for the timeout code in 
> htc_config_pipe_credits() to be executed, as shown below:
> 
>          time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
>          if (!time_left) {
>                  dev_err(target->dev, "HTC credit config timeout\n");
>                  return -ETIMEDOUT;
>          }
> 
> When this timeout happens, is the skb leaked?

No, the submitted SKB (via htc_issue_send()) will always have a TX completion
invocation. The actual completion of target->cmd_wait happens via a different
code-path, htc_process_conn_rsp() in ath9k_htc_rx_msg().

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux