On Tue, 2013-01-08 at 10:57 +0800, Chen Gang wrote: > 于 2013年01月08日 01:22, Joe Perches 写道: > > On Mon, 2013-01-07 at 08:47 +0100, Johannes Berg wrote: > >> > print_ssid() is used in two or > >> > three legacy drivers only, not in any modern driver, and is unlikely to > >> > be used in the more modern drivers due to tracing etc. > > Swell. It was just another way to correct those overrun > > errors Chen Gang found. > > > sorry, I am not quite clear about what you said. You found some overrun errors and proposed a patch. Your solution could output incomplete SSIDs. I proposed a different patch that would fully output any binary/non-ascii printable SSID. I also proposed a different mechanism to avoid the overrun via printk and also avoid possibly excessive stack consumption as a means for John Linville to select 1 of the above options. I don't care what is done with any of those proposed patches. Clear? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
