Hi Malcolm, One quick point of note, when releasing newer versions of your patches, it's preferred that you change the subject to something like [PATCH v2 1/3] staging: vt6656: change bssdb/rxtx/wpa2 to new structures instead of [PATCH 1/3] staging: vt6656: change bssdb/rxtx/wpa2 to new structures v2 Everything outside the square brackets will go into the kernel log and things like "version 2" or "rebased version" have no real meaning outside the original discussion of the patch. On Tue, Jan 8, 2013 at 10:34 AM, Malcolm Priestley <tvboxspy@xxxxxxxxx> wrote: > rebased version Also, notes about the patch, e.g. "rebased version" are generally put after the description ... > This patch cleans up function declarations, definitions and local variables > where appropriate replacing types defined in "type.h" with linux/types.h. > > Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx> > --- ... here. > drivers/staging/vt6656/bssdb.c | 293 ++++++++-------- > drivers/staging/vt6656/bssdb.h | 130 ++++--- > drivers/staging/vt6656/rxtx.c | 757 +++++++++++++---------------------------- > drivers/staging/vt6656/rxtx.h | 31 +- > drivers/staging/vt6656/wpa2.c | 19 +- > 5 files changed, 452 insertions(+), 778 deletions(-) Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html