On Sun, Jan 06, 2013 at 10:02:14PM -0500, Nickolai Zeldovich wrote: > > Good catch, but the patch would be better titled "mwl8k.c: avoid > > having a working driver", as the station_id return code _is_ needed > > by the caller in case of success. > > I'm not quite sure what you mean -- is there something subtle going on > here? I believe my patch preserves the semantics of the original > code: it returns the value of p->station_id if mwl8k_post_cmd() > returned 0, but it just does so by reading p->station_id first before > calling kfree(cmd). Oops! You're right. Sorry about that. /me goes to order some crow for dinner -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html