On Sat, Dec 22, 2012 at 06:18:26PM -0500, Solomon Peachy wrote:
> + size_t pos = buf->data - buf->begin;
> + size_t size = pos + extra_size;
> +
> +
> + if (size & (FWLOAD_BLOCK_SIZE - 1)) {
> + size &= FWLOAD_BLOCK_SIZE;
> + size += FWLOAD_BLOCK_SIZE;
> + }
I think this should be
size = round_up(size, FWLOAD_BLOCK_SIZE);
Otherwise it fails if size > 2 * FWLOAD_BLOCK_SIZE (it may never be,
but it still looks wrong).
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
