Search Linux Wireless

Re: [PATCHv5 7/8] mac80211: add ap channel switch command/event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-12-13 at 14:58 +0100, Simon Wunderlich wrote:

> +	mutex_lock(&local->mtx);
> +	if (local->ap_cs_chandef.chan->flags & IEEE80211_CHAN_RADAR) {
> +		sdata_info(sdata, "changing to DFS channel\n");
> +		/* when changing to a DFS channel, stop AP. Userspace must
> +		 * restart AP or do start radar detection first.
> +		 */
> +		stop_ap = true;

I don't see any value in this. You might just as well simply forbid
requesting a channel change to a DFS channel, hostapd could then stop
instead of doing the switch.

> +	} else {
> +		/* update the device channel directly */
> +		sdata_info(sdata, "changing to non-DFS channel\n");
> +
> +		/* TODO: _oper_channel is deprecated ... use
> +		 * vif_release/use_channel instead? In this case, we must make
> +		 * sure that interface is down first ...
> +		 */

Well, most likely need to modify the existing channel context instead.
However, that's tricky, and what if there are other interfaces, what
happens to those?

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux