Search Linux Wireless

Re: [PATCH 5/7] ath6kl: convert ath6kl_info/err/warn macros to real functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-12-27 at 13:44 +0200, Kalle Valo wrote:

> +	va_start(args, fmt);
> +	vaf.va = &args;
> +	ret = ath6kl_printk(KERN_WARNING, "%pV", &vaf);
> +	va_end(args);

Note that by inserting the tracing here later, you're relying on the
fact that "%pV" does va_copy(). This isn't true in all kernel versions,
I think there's on version or so where %pV is supported but didn't
va_copy(). That may lead to problems (I don't remember what kind) here.

This is relevant for compat only, I think I carry a patch there to add
va_copy() into the tracing or something.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux