On 2012-12-22 16:45, Solomon Peachy wrote:
The cw1200 is a thick-ish MAC that manages many aspects of AP operation
in the firmware. As such, it only supports a limited number of clients.
[...]
+#if defined(CONFIG_CW1200_STA_DEBUG)
+#define ap_printk(...) printk(__VA_ARGS__)
+#else
+#define ap_printk(...)
+#endif
Please kill CONFIG_CW1200_*_DEBUG and use pr_debug or other dyndbg
interface instead. Goes for all files.
[...]
+#if defined(CONFIG_CW1200_USE_STE_EXTENSIONS)
Please get rid of CONFIG_CW1200_USE_STE_EXTENSIONS. The "extensions" is standard stuff anyway.
+ priv->cqm_beacon_loss_count =
+ info->cqm_beacon_miss_thold;
+ priv->cqm_tx_failure_thold =
+ info->cqm_tx_fail_thold;
+ priv->cqm_tx_failure_count = 0;
I remember fixing a tricky bug here. When loosing BSS the driver can in
some case leave
priv->bss_loss_status to > CW1200_BSS_LOSS_NONE.
This blocks further processing of the BSS_LOST events from firmware
causing link loss detection to fail.
The fix was to clean up bss_lost_status here before canceling
bss_loss_work and connection_loss_work:
priv->delayed_link_loss = 0;
spin_lock(&priv->bss_loss_lock);
priv->bss_loss_status = CW1200_BSS_LOSS_NONE;
spin_unlock(&priv->bss_loss_lock);
+ cancel_delayed_work_sync(&priv->bss_loss_work);
+ cancel_delayed_work_sync(&priv->connection_loss_work);
+#endif /* CONFIG_CW1200_USE_STE_EXTENSIONS */
//Pontus
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
