Search Linux Wireless

Re: [PATCH v2 2/3] mac80211_hwsim: beacon at beacon interval

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 21, 2012 at 03:36:24PM +0100, Johannes Berg wrote:
> On Thu, 2012-12-20 at 10:57 -0800, Thomas Pedersen wrote:
> 
> > +	else if (!hrtimer_is_queued(&data->beacon_timer)) {
> > +		u64 tsf = le64_to_cpu(__mac80211_hwsim_get_tsf(data));
> 
> This is odd, you haven't even modified __mac80211_hwsim_get_tsf() yet?
> Also, there's mac80211_hwsim_get_tsf() (although I'd argue that they
> should be the other way around wrt. endianness)

You're right, mac80211_hwsim_get_tsf() is less redundant. Also I guess
the timebase changes should go into the first patch.

Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux