On Thu, 2012-12-20 at 10:57 -0800, Thomas Pedersen wrote:
> @@ -896,7 +897,8 @@ static void mac80211_hwsim_stop(struct ieee80211_hw *hw)
> {
> struct mac80211_hwsim_data *data = hw->priv;
> data->started = false;
> - del_timer(&data->beacon_timer);
> + hrtimer_cancel(&data->beacon_timer);
> + tasklet_kill(&data->bcn_tasklet);
> wiphy_debug(hw->wiphy, "%s\n", __func__);
Hm this seems odd, why is it stopped here rather than when beaconing is
stopped? Or does it do both?
> @@ -1084,12 +1096,12 @@ static void mac80211_hwsim_bss_info_changed(struct ieee80211_hw *hw,
>
> if (changed & BSS_CHANGED_BEACON_INT) {
> wiphy_debug(hw->wiphy, " BCNINT: %d\n", info->beacon_int);
> - data->beacon_int = 1024 * info->beacon_int / 1000 * HZ / 1000;
> - if (WARN_ON(!data->beacon_int))
> - data->beacon_int = 1;
> - if (data->started)
> - mod_timer(&data->beacon_timer,
> - jiffies + data->beacon_int);
> + data->beacon_int = ns_to_ktime(info->beacon_int * 1024 * 1000);
> + if (WARN_ON(!ktime_to_ns(data->beacon_int)))
> + data->beacon_int = ns_to_ktime(1000 * 1000);
Can that warning really happen? It seems it should be checking
info->beacon_int rather than data->beacon_int? Why convert back and
forth?
Also the default here seems very very small, that's like less than 1ms
beacon interval (not even in TU)?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
