Search Linux Wireless

Re: [RFC PATCH 02/10] mac80211: A-MPDU Tx add MLME structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> +#define HT_AGG_STATE_INITIATOR_MSK      BIT(HT_AGG_STATE_INITIATOR_SHIFT)

I think you should use a tab here instead of spaces ;)

>  struct sta_ampdu_mlme {
>  	struct tid_ampdu_rx tid_rx[STA_TID_NUM];
> +	struct tid_ampdu_tx tid_tx[STA_TID_NUM];
>  	spinlock_t ampdu_rx;
> +	spinlock_t ampdu_tx;
> +	u8 dialog_token_allocator;
>  };
>  
>  struct sta_info {
> @@ -148,6 +175,7 @@ struct sta_info {
>  					     of this STA */
>  	struct sta_ampdu_mlme ampdu_mlme;
>  	u8 timer_to_tid[STA_TID_NUM];	/* convert timer id to tid */
> +	u8 tid_to_tx_q[STA_TID_NUM];	/* map tid to tx queue */

I wonder if we're reaching a point where this is blowing up the sta info
stuff enough to warrant putting in ifdefs for the aggregation stuff...
When you have a small AP where you know it won't be able to do
aggregation due to the hardware, you could turn it off and save a
significant amount of memory per sta-info. Not sure though, and we
should definitely do it *after* this patch series if at all.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux