Search Linux Wireless

Re: [PATCH 04/11] brcmsmac: radio on led support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/05/2012 04:09 PM, Hauke Mehrtens wrote:
>> +	if (state)
>> > +		bcma_cc_set32(cc_drv, BCMA_CC_GPIOOUT, gpio_out);
>> > +	else
>> > +		bcma_cc_mask32(cc_drv, BCMA_CC_GPIOOUT, ~gpio_out);
> Could you use bcma_chipco_gpio_out() instead, in the mips tree is a
> patch adding locking around the gpio registers. bcma_cc_set32 and
> bcma_cc_mask32 are not atomic. Two threads are accessing them in
> parallel will cause problems. The patches in the mips tree are adding
> full libgpio support, so it should also be possible to register the gpio
> from the generic gpio system and use the generic gpio functions.
> 

Sure. I will rework the patch.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux