On Fri, 2012-11-23 at 12:18 -0800, Marco Porsch wrote: > + /* mesh power save */ > + enum nl80211_mesh_power_mode nonpeer_ps_mode; > + u8 ps_peers_light_sleep; > + u8 ps_peers_deep_sleep; u8? really? > + ieee80211_set_sta_mesh_local_ps_mode(sta, > + mshcfg->power_mode, 100); Maybe this function needs some refactoring if the indentation is this deep? :) In any case that looks odd, I think you should either break all parameters or do the normal lined-up indentation. > + u8 light_sleep_cnt = 0; > + u8 deep_sleep_cnt = 0; Again, u8? Also in this function: you aren't bothered by the lack of locking at all, are you? Well I am :-P > + setup_timer(&sta->local_ps_mode_timer, > + ieee80211_sta_mesh_local_ps_mode_timer, > + (unsigned long) sta); suggest you run checkpatch -- I'm not your whitespace nanny. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
