On Jan 9, 2008 6:50 PM, Ivo van Doorn <ivdoorn@xxxxxxxxx> wrote:
> Hi,
>
> > > @@ -651,6 +652,7 @@ static int ieee80211_ioctl_siwtxpower(struct net_device *dev,
> > > if (local->hw.conf.radio_enabled != !(data->txpower.disabled)) {
> > > local->hw.conf.radio_enabled = !(data->txpower.disabled);
> > > need_reconfig = 1;
> > > + ieee80211_led_radio(local, local->hw.conf.radio_enabled);
> >
> > Not sure but isn't it cleaner to push it to ieee80211_hw_config().
> > This will cover also ieee80211_open and maybe in the future also
> > cfg80211
> > Will it be so bad to call led_radio even the led is already lit?
>
> Well that means it will be called quite often, and although it would perhaps
> not matter that much, I don't consider it a clean solution.
If you have one physical led mapped to few triggers as it is on
current laptops it will be probably complicate few things so after
all I'm fine with how it is now.
> We could move it to ieee80211_hw_config() eventually, but I think we should
> first implement some kind of "what config option changed" handling. That
> would benefit drivers as well since they should now handle that to prevent
> configuring _everything_ when hw_config() is called.
You are talking from my heart.
Tomas
> Ivo
>
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
