On Mon, Dec 31, 2007 at 12:11:20AM +0100, Sam Ravnborg wrote: > # If RC algorithm in build-in > rate-rc-y := rc80211_pid_algo.o > rate-rc-$(CONFIG_MAC80211_DEBUGFS) += rc80211_pid_debugfs.o > > # If RC algorithm is modular > rate-rc-m := rc80211_pid.o > > mac80211-y += ieee80211.o key.o util.o event.o > mac80211-$(CONFIG_MAC80211_LEDS) += ieee80211_led.o > mac80211-$(CONFIG_NET_SCHED) += wme.o > mac80211-$(CONFIG_MAC80211_DEBUGFS) += debugfs.o debugfs_sta.o > mac80211-$(CONFIG_MAC80211_DEBUGFS) += debugfs_netdev.o debugfs_key.o > > # And this part select the rate algorithm > mac80211-$(CONFIG_MAC80211_SIMPLE) += rc80211_simple.o > mac80211-$(CONFIG_MAC80211_RC_PID) += $(rate-rc-$(CONFIG_MAC80211_RC_PID)) > > # Modular rate algorithm was assigned to mac80211-m - make it a separate module > obj-m += $(mac80211-m) Why don't we just build the rate control algorithms entirely separate useing obj-$(FOO) ? If they're modular that lets them be their own module, and if they're built-in they'll still go into built-in.o. But why do we want to have rc80211_pid.o only if modular and rc80211_pid_algo.o only if built-in? This seems like a complete mess to me. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html