Search Linux Wireless

Re: Warning emited by 2.6.24-rc6-git5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> If it helps as reference, rt2x00 allocates and initializes the data as follows:
> 
> 		skb_reserve(skb, NET_IP_ALIGN);
> 		skb_put(skb, desc.size); /* Always a multiple of 4 bytes */
> 		memcpy(skb->data, entry->data_addr, desc.size);

So why do you copy all the data anyway? You have DMA queues and no need
to not have the hardware dump the data into the frame to start with, no?

In any case, with wireless NET_IP_ALIGN is pretty useless unless you
want to add two to it and then align the result. Maybe the mac80211
warning should be relaxed to take NET_IP_ALIGN into account.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux