Search Linux Wireless

Re: [PATCH] mac80211: Fix rate reporting regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting stefano.brivio@xxxxxxxxx:

+	fc = le16_to_cpu(hdr->frame_control);
+	if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
+	    is_multicast_ether_addr(hdr->addr1) || !sta) {

Oops, we check here that sta is not NULL, so we don't dereference it in case. I shouldn't even try to comment things by looking at them using my crappy webmail.

You need to separate the if (!sta) and the if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA || is_multicast_ether_addr(hdr->addr1)) branches anyway, in order to fix refcounting.


--
Ciao
Stefano



-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux