Hi,
After a bit of rework in my patches, we only have two places left where
we use the 802.1X flag:
tx.c:
if (unlikely(sdata->ieee802_1x_pac &&
!(sta_flags & WLAN_STA_AUTHORIZED) &&
[...]
rx.c:
if (unlikely(rx->sdata->ieee802_1x_pac &&
(!rx->sta || !(rx->sta->flags & WLAN_STA_AUTHORIZED)))) {
[...]
That has me wondering if the control is actually useful. Instead of
checking this flag, we could simply require that hostapd sets the
WLAN_STA_AUTHORIZED flag on all stations if 802.1X is disabled. Do you
(or anyone else) see any problem with this?
We would of course have to set the WLAN_STA_AUTHORIZED flag on all
stations we add from within mac80211, i.e. the AP we're associating to,
other IBSS stations and the WDS peer, but that's trivial.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
