On Tue, 2007-12-18 at 22:01 -0800, Reinette Chatre wrote: > if log_len is larger than 4K then we are killing the stack. > allocate on heap instead and limit size to what practically can > be used (PAGE_SIZE) > > Is it possible for this to get into 2.6.24? > > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> ACK. > --- > + /* not using min() because of its strict type checking */ > + log_size = sizeof(*log) * log_len < PAGE_SIZE ? > + sizeof(*log) * log_len : PAGE_SIZE; A (u32) cast should work. But I don't think it's a big issue. Thanks, -yi - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html