Search Linux Wireless

Re: [PATCH 6/8] mac80211: A-MPDU Rx adding BAR handling capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> (lets put aside the AP that bombed me with 749 BARs over 30
> seconds ;-) i really think it was a buggy functionality of the AP
> there)

Heh. Fun.

> > > +             else if ((fc & IEEE80211_FCTL_STYPE) ==
> > > +                                             IEEE80211_STYPE_BACK_REQ) {
> > > +                     switch (type) {
> > > +                     case IEEE80211_IF_TYPE_STA:
> > > +                             return hdr->addr2;
> > > +                     case IEEE80211_IF_TYPE_AP:
> > > +                             return hdr->addr1;
> > > +                     }
> >
> > Doesn't that result in a compiler warning? And what does happen if we
> > receive a BACK_REQ when we're an IBSS/MESH?

I was obviously wrong here, it doesn't result in a compiler warning
since you didn't use the enum type. It will once you use the enum type.

> IBSS is not supporting 802.11n currently (spec decision)

Ok.

> MESH i am not familier enough yet to answer. are you sure it supports 11n?

I guess we should just return NULL in all other cases here. But please
enumerate the cases explicitly so that people who add new interface
types get warnings, i.e. don't use a default: statement in a switch
(interface type)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux