On Mon, 2007-12-17 at 01:20 +0100, mattias.nissler@xxxxxx wrote: > This makes debugfs use its own file_operations for the value accessor files > created by debugfs_create_XXX. Having that, we can also have proper versions > for signed integers. I think I'd probably prefer if this didn't duplicate all the fs/libfs.c simple attribute functionality but extended libfs instead to define attributes that can have their own print/scan functions. Or something like that. As far as I can tell, the only reason you're doing this huge amount of code duplication is the "(unsigned long long)" cast in fs/libfs.c, or am I missing something? You might even be able to get around that: define the get() function in simple_attr to return unsigned long long (rather than u64 as it does now) and then remove the cast. Then, %lld will still print a negative number if applicable. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
