Search Linux Wireless

Re: [patch 3/9] mac80211: Add PID controller based rate control algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	/* We need to do an arithmetic right shift. ISO C says this is
> +	 * implementation defined for negative left operands. Hence, be
> +	 * careful to get it right, also for negative values. */
> +	adj = (adj < 0) ? -((-adj) >> (2 * RC_PID_ARITH_SHIFT)) :
> +			  adj >> (2 * RC_PID_ARITH_SHIFT);

That looks... weird.

As far as I know all compilers the kernel can use will do an arithmetic
right shift if the data type is signed.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux