Search Linux Wireless

Re: b43 problem with led trigger registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 16 December 2007 20:59:36 Johannes Berg wrote:
> 
> > I have no idea where we enter atomic state.
> 
> Uh huh...
> 
> drivers/leds/led-triggers.c:led_trigger_register:
> 
> |        read_lock(&leds_list_lock);
> |        list_for_each_entry(led_cdev, &leds_list, node) {
> |                down_write(&led_cdev->trigger_lock);
> 
> introduced in
> 
> commit dc47206e552c0850ad11f7e9a1fca0a3c92f5d65
> Author: Richard Purdie <rpurdie@xxxxxxxxx>
> Date:   Sat Nov 10 13:29:04 2007 +0000
> 
>     leds: Fix led trigger locking bugs
> 
> I guess the read_lock needs to be a mutex/rw semaphore.

Uh, yes. Was this patch tested at all?

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux