Michael Buesch wrote:
On Thursday 13 December 2007 06:32:11 Larry Finger wrote:
logic in the request_module("rfkill-input") section. Now, the code is
Ehm, no. Wait.
There was a
#ifdef CONFIG_RFKILL_INPUT_MODULE
That is only defined if rfkill-input is a module, right?
Correct and CONFIG_RFKILL_INPUT is defined if the code is built_in. The "most correct" logic for
this section would be:
if (built_in)
all is OK.
if (module)
load it.
If (!built_in && !module)
warn that the LED will not work.
In the version I sent you, the logic is:
if (!built_in) {
load module
if (err)
print message that it will not work
}
To my thinking, the second version is close enough. the only extra step it does is to try to load
the module even when it has not been built, but it does end up with the warning being printed.
Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
