Search Linux Wireless

Re: [PATCH] try 2: mac80211: Fix swapped parameters to ieee80211_set_channel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 13, 2007 at 01:30:25PM +0100, Johannes Berg wrote:
> 
> > iwconfig wlan0 freq 5240
> 
> man iwconfig(8)
> 
>        freq/channel
>               Set the operating frequency or channel in the  device.  A  value
>               below 1000 indicates a channel number, a value greater than 1000
>               is a frequency in Hz. You may append the suffix k, M or G to the
>               value  (for  example,  "2.46G"  for  2.46 GHz frequency), or add
>               enough ???0???.

Yup, see my last email. 

However this description does not match the implementation. The
implementation is that its a channel if e = 0. My "frequency" is > 1000,  
but it was still interpreted as a channel. Looking at the
implementation of iw_float2freq(), the description should be that a
value less than 1e9 is a channel. 

So there should really be a check in the user space tools which says
that values between 1000 and 1e9 are invalid. This would catch errors
like the one i made for both 2.4GHz and 5GHz.

     Andrew

-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux