On Dec 10, 2007 6:25 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > You could even code the "set little tiny bit in it" as > > struct->flags |= cpu_to_le32(flag value); > > which all other drivers do. I hope you grep the kernel before you wrote this :). No iwlwifi is not the only driver that does that. I cannot claim invented this. > It boils down to what I just said: > > Most people prefer making endian conversions explicit in the code while > you're hiding it in defines which is unintuitive if only because it > differs from what everybody else does. We did it because it's more readable for us you are free to think differently. If you referring to everybody else as the code of other drivers then they are different because the HW is different. Just make it clear I'm part of this argument because I believe I'm correct from technical point.. We didn't hide anything and we are glad that other people contribute to the iwlwifi. any other suggestions are pure speculations. Personally I think this conversation was saturated enough. I'll reconsider all your suggestions mainly the cpup stuff that I wasn't aware of. Thanks Tomas > johannes > - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
