Search Linux Wireless

Re: [PATCH 14/48] libertas: fix data packet size errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2007-12-10 at 16:49 +0100, Michael Buesch wrote:
> > +             u16 sz = cpu_to_le16(resp->size) - S_DS_GEN;
> 
> Whoops, something's wrong here.
> You are subtracting from a LE value.

It should have been le16_to_cpu(), not cpu_to_le16(). It works as it is
on all real hardware, although it makes sparse unhappy. Holger later
fixed a bunch of such things (including this one along with some _real_
errors) in patch #21.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux