Search Linux Wireless

Re: [PATCH 1/1] mac80211: pass in PS_POLL frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +/* IEEE 80211.11 minimal headers length */
> > +#define IEEE80211_HDR_MIN_LEN_CTRL 16
>
> Where does this value 16 come from? It is likely the shortest length one
> would receive from hardware/firmware in normal mode, but it is not the
> shortest length for a valid IEEE 802.11 control frame. Both CTS and ACK
> frames have only 10 octets in the header (just one address). Having
> IEEE80211_HDR_MIN_LEN_CTRL defined to 16 would be a bit confusing.. CTS
> and ACK frames are received at least in monitor mode, so these frames
> with 10 octet headers will need to be processed in some cases.

this check comes after monitor interface has been fed, so it shouldn't
damage it.
My intention in the name was "min length for a frame that i want to
pass" so i see why it can cause confusion. As no good name for it
comes to my mind i think i will drop the #defines , add remarks to
explain length use, and will welcome any change for better naming
convention.

ron

>
> --
> Jouni Malinen                                            PGP id EFC895FA
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux