On Sat, 2007-12-08 at 12:29 +0100, Johannes Berg wrote:
> > + /* Send management frames and broadcast/multicast data using lowest
> > + * rate. */
> > + fc = le16_to_cpu(hdr->frame_control);
> > + if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
> > + (hdr->addr1[0] & 0x01))
> > + sel->rate = rate_lowest(local, mode, sta);
>
> I'm not sure but I don't think we want this. And you should use
> is_multicast_addr() or whatever it's called.
This piece comes directly from the old "simple" algo. You're right about
is_multicast_addr. I agree this is something we might to get rid of, but
I leave that decision to you.
>
> > + /* If a forced rate is in effect, select it. */
> > + sdata = IEEE80211_DEV_TO_SUB_IF(dev);
> > + if (sdata->bss && sdata->bss->force_unicast_rateidx > -1)
> > + sel->rate = &mode->rates[sdata->bss->force_unicast_rateidx];
>
> That's good.
>
> > + /* If we haven't found the rate yet, ask the rate control algo. */
> > + if (!sel->rate)
> > + ref->ops->get_rate(ref->priv, dev, mode, skb, sel);
>
> > + /* Select a non-ERP backup rate. */
> > + if (!sel->nonerp) {
> > + for (i = 0; i < mode->num_rates - 1; i++) {
> > + struct ieee80211_rate *rate = &mode->rates[i];
> > + if (sel->rate->rate < rate->rate)
> > + break;
> > +
> > + if (rate_supported(sta, mode, i) &&
> > + !(rate->flags & IEEE80211_RATE_ERP))
> > + sel->nonerp = rate;
> > + }
> > + }
>
> That I'm not sure about. This is the fallback rate?
Yes. It's after the get_rate() call so the algorithm can override it.
But if it doesn't we compute it ourselves.
Mattias
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
