Search Linux Wireless

Re: [PATCH] libertas: fix data packet size errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2007-12-06 at 10:15 +0100, Holger Schurig wrote:
> 
> +       /* This is a workaround for a firmware that reports too much
> +        * bytes */
> +       *len -= 8
>         ret = 0;

You might want another semicolon somewhere in there?

And if we're not looking at the length at all, that's bad. We should
probably at _least_ compare it with the size field, to make sure we got
everything that was sent, and that we're not reading off the end of the
buffer.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux