Michael Buesch wrote: > On Wednesday 28 November 2007 16:38:27 Larry Finger wrote: >> Since addition of the rfkill callback, the LED associated with the off/on >> switch on the radio has not worked because essential data in the rfkill >> structure is missing. When that problem was fixed, difficulties in circular >> locking surfaced. This patch fixes part of the regression in that the LED >> is turned on if the radio switch is on at startup. Adding the code to toggle >> the LED with the switch will be more involved and would likely miss the 2.6.24 >> window. >> >> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >> --- >> >> John and Michael, >> >> I was able to get the full functionality working, but with two significant >> problems: (1) the LED toggled only with a switch off-on sequence, not with >> each switch change and (2) the module would no longer unload cleanly due to >> circular locking. I will be essentually off-line after today, and I hope that >> this hack, which will make the LED appear to work correctly, can be pushed >> into 2.6.24 as it is a fix, but has minimal code impact. Nearly all of the >> changes are needed just to make the LED on routine available to startup. >> Furthermore, I'm certain these changes will be needed when the complete fix >> is available. > > That completely shortcuts the "behaviour" logic. > This patch trades one bug for another. > It will get other people upset, because their LEDs don't work as expected anymore. > > This is not a showstopper bug and there is no need to introduce dirty > fixes that trade one bug for another. > I'm pretty sure that this patch will break LEDs on my asus card. I didn't > try that, though. Please try the patch at least enough to see if it breaks the LEDs on your card. I don't think it will. The reason that part was needed in the more complete code is that there is no key event to turn the rfkill LED on otherwise. I agree that this is not a showstopper, but it is annoying. It is, however, your call. Larry - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
