Search Linux Wireless

Re: [RFC/T V2] b43: Fix Radio On/Off LED action

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 27 November 2007 22:22:22 Larry Finger wrote:
> > I'm wondering who causes this deadlock. "registered" should be false if
> > we are called back from rfkill_initialize, so it should return early before
> > the lock.
> 
> The following code has the competing lock:
> 
> static int rfkill_toggle_radio(struct rfkill *rfkill,
>                                 enum rfkill_state state)
> {
>         int retval;
> 
>         retval = mutex_lock_interruptible(&rfkill->mutex);
>         if (retval)
>                 return retval;
> 
>         if (state != rfkill->state) {
>                 retval = rfkill->toggle_radio(rfkill->data, state);
>                 if (!retval) {
>                         rfkill->state = state;
>                         rfkill_led_trigger(rfkill, state);
>                 }
>         }
> 
>         mutex_unlock(&rfkill->mutex);
>         return retval;
> }

So it's a lock dependency between rfkill->mutex and wl->mutex?
So, now comes the question that really matters. Who is the caller
of rfkill_toggle_radio, in the case where it crashes?

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux