(Trimmed CC list a bit, hopefully didn't cut anyone interested out) On Monday 26 November 2007 19:59:50 Tony Breeds wrote: > On Tue, Nov 20, 2007 at 06:53:15PM +0530, Kamalesh Babulal wrote: > > Hi Andrew, > > > > The kernel build fails, with following message > > > > LD drivers/net/wireless/built-in.o > > drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init': > > (.opd+0x180): multiple definition of `rtl8225z2_rf_init' > > drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here > > drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init': > > /root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: > > multiple definition of `.rtl8225z2_rf_init' > > drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireles > >s/rtl8180_rtl8225.c:561: first defined here ld: Warning: size of symbol > > `.rtl8225z2_rf_init' changed from 3836 in drivers/net/wireless/rtl8180.o > > to 3544 in drivers/net/wireless/rtl8187.o > > <snip> > > The patch below is a little ugly but will allow allyesconfig to work. I > don't know enough about the Realtek devices to make intellegent > suggestions on how to fix this particular problem. Clearly the 2 > drivers share a lot of common code so perhaps they can be merged? > I would rather have a patch to temporarily not allow them to be built into the kernel. (or only allow one at a time to be built as a module) There's no issues when these drivers are compiled as modules. It's mostly the rtl8225 radio tuning code that's similar. They're not exactly the same though, so it'll be a bit messy to merge the usb rtl8225 radio tuning and pci rtl8225 radio tuning code. However, I do think it'll be better overall so the merger of that code is planned. -Michael Wu
Attachment:
signature.asc
Description: This is a digitally signed message part.
