On Fri, 2007-11-23 at 21:27 +0100, Johannes Berg wrote: > > > --- everything.orig/drivers/net/wireless/b43/xmit.c 2007-11-22 23:36:05.668676810 +0100 > > > +++ everything/drivers/net/wireless/b43/xmit.c 2007-11-22 23:36:22.668677190 +0100 > > > @@ -489,7 +489,6 @@ void b43_rx(struct b43_wldev *dev, struc > > > } > > > wlhdr = (struct ieee80211_hdr *)(skb->data); > > > fctl = le16_to_cpu(wlhdr->frame_control); > > > - skb_trim(skb, skb->len - FCS_LEN); > > > > > > if (macstat & B43_RX_MAC_DEC) { > > > unsigned int keyidx; > > > > > > > > > > > > > > > > Does this work with all encryption and non-encryption modes? > > There was a crypto related reason why we snipped off the FCS. > > Maybe that's gone, though. > > Yeah there was but to be honest I couldn't think of the reason any more > and I can't see one here because right afterwards the only thing we do > is hand the frame to mac80211. Ah, I remember now. We were doing "device hides WEP" and snipped off the ICV so didn't want to move around the FCS. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part