On Wed, Nov 21, 2007 at 04:17:34PM +0100, Johannes Berg wrote: > > When I connect to an AP with wpa, then I receive deauth frame, > > ieee80211_rx_mgmt_deauth will be called, which will call > > ieee80211_set_associated(dev, ifsta, 0); to disconnect. In function > > ieee80211_set_associated, it calls wireless_send_event with SIOCGIWAP > > event and memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN). This sounds correct. > > wpa_supplicant will > > receives this event then call mac80211 to remove any old security key, > > the problem it will pass 00:00:00:00:00:00 as station address. This sounds broken. wpa_supplicant should remove the key for the previous BSSID. > > ieee80211_set_encryption will fail since there are no station with > > 00:00:00:00:00:00. This will leave the old key which causes the problems > > in the next reconnection. This sounds correct behavior. > Interesting. I'd think this is a wpa_supplicant bug, Jouni, how is the > security wext stuff supposed to work here? Agreed, this sounds like a bug in wpa_supplicant. Unicast keys should be removed with their correct address. I think this used to work, but maybe some of the changes in BSSID processing in disassociation cases caused the old BSSID to be forgotten. > > diff --git a/net/mac80211/ieee80211_ioctl.c b/net/mac80211/ieee80211_ioctl.c > > @@ -97,7 +97,10 @@ static int ieee80211_set_encryption(struct net_device *dev, u8 *sta_addr, > > - sta = sta_info_get(local, sta_addr); > > + if (is_zero_ether_addr(sta_addr)) > > + sta = sta_info_get(local, sdata->u.sta.bssid); > > + else > > + sta = sta_info_get(local, sta_addr); NAK. I don't think this is the correct fix here. -- Jouni Malinen PGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
