On Nov 21, 2007 4:07 AM, Bruno Randolf <bruno@xxxxxxxxxxxxx> wrote: > added new macros ATH5K_INFO, ATH5K_WARN and ATH5K_ERR for more consistent > logging inside ath5k. they prepend "ath5k phyX:" to all lines so we can > distinguish between different cards in multi-card setups. ATH5K_WARN and > ATH5K_ERR use net_ratelimit(), so they can be used anywhere without having to > check net_ratelimit() seperately. > > the macros get a reference to sc, so we can automatically add additional > information: right now it is used to get the phy name, but having this in one > central place gived us the flexibility to switch to dev_info/warn/... or others > instead too. i think using "phyX" makes the output most readable and easier to > match with the output from mac80211. in cases where we don't have sc available > we still use ATH5K_PRINTF. > > changed all printk, most dev_info and most AR5K_PRINTF lines to use these > macros instead. deleted AR5K_PRINT because it's easy to use ATH5K_PRINTF > instead. > > for base.c > Changes-licensed-under: 3-clause-BSD > > for all others... > Changes-licensed-under: ISC > > Signed-off-by: Bruno Randolf <bruno@xxxxxxxxxxxxx> Thanks for splitting this. I believe you missed some notes I made in the previous e-mail. The boring legal notes are specially important. Luis - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
