Shaddy Baddah wrote:
Interestingly, after performing the above actions, I am now getting
additional log messages:
SoftMAC: Open Authentication completed with GG:GG:GG:GG:GG:GG
Kernel unaligned access at TPC[100df410]
ieee80211softmac_handle_assoc_response]
Kernel unaligned access at TPC[100df548]
ieee80211softmac_handle_assoc_response]
This one doesn't include any offsets, did the line get cut off?
I'm spoilt by the luxuries of i386/x86_64 and am not clear on exactly
what forms an unaligned access. I am wondering if this line is causing it:
network = ieee80211softmac_get_network_by_bssid_locked(mac,
resp->header.addr3);
addr3 is offset 20 bytes in the struct and is 6 bytes long. Because 20
is not evenly divisible by 6 does that make it an unaligned access?
Is there any documentation I can read on this topic? In my current
uneducated state I'm likely to write further code with these problems...
ADDRCONF(NETDEV_CHANGE): eth2: link becomes ready
Kernel unaligned access at TPC[100d03ec] ieee80211_copy_snap+0x74/0x78
[ieee802]
Kernel unaligned access at TPC[100d03ec] ieee80211_copy_snap+0x74/0x78
[ieee802]
Kernel unaligned access at TPC[100d03ec] ieee80211_copy_snap+0x74/0x78
[ieee802]
Kernel unaligned access at TPC[100d03ec] ieee80211_copy_snap+0x74/0x78
[ieee802]
Kernel unaligned access at TPC[100d03ec] ieee80211_copy_snap+0x74/0x78
[ieee802]
This one should be fixed by the attached patch. Sorry for not sending it
sooner, the contributor has not yet solved all problems and I was
waiting to see if more patches would come.
Kernel unaligned access at TPC[100ee624] do_rx+0x394/0x5ec [zd1211rw]
Kernel unaligned access at TPC[100ee62c] do_rx+0x39c/0x5ec [zd1211rw]
Kernel unaligned access at TPC[100ee638] do_rx+0x3a8/0x5ec [zd1211rw]
Kernel unaligned access at TPC[100ee668] do_rx+0x3d8/0x5ec [zd1211rw]
Kernel unaligned access at TPC[100ee670] do_rx+0x3e0/0x5ec [zd1211rw]
These might be solved by the patch David sent to the list a few days ago
(thanks!). Have you applied it? If you can confirm it helps I will send
it up through John.
Thanks,
Daniel
[PATCH] ieee80211: fix unaligned access in ieee80211_copy_snap
From: Daniel Drake <dsd@xxxxxxxxxx>
Based on a patch from Jun Sun.
Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>
diff --git a/net/ieee80211/ieee80211_tx.c b/net/ieee80211/ieee80211_tx.c
index a4c3c51..6d06f13 100644
--- a/net/ieee80211/ieee80211_tx.c
+++ b/net/ieee80211/ieee80211_tx.c
@@ -144,7 +144,8 @@ static int ieee80211_copy_snap(u8 * data, u16 h_proto)
snap->oui[1] = oui[1];
snap->oui[2] = oui[2];
- *(u16 *) (data + SNAP_SIZE) = htons(h_proto);
+ h_proto = htons(h_proto);
+ memcpy(data + SNAP_SIZE, &h_proto, sizeof(u16));
return SNAP_SIZE + sizeof(u16);
}
