> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Tuesday, November 20, 2007 11:30 AM > To: Cahill, Ben M > Cc: Zhu, Yi; linville@xxxxxxxxxxxxx; > linux-wireless@xxxxxxxxxxxxxxx; Abbas, Mohamed > Subject: RE: [PATCH] mac80211: hardware scan rework (V2) > > > > The firmware-driven scan on 4965 (3945 also) returns to the > original > > channel by itself. [...] > > Right. Thanks for the description. > > > Once done with the list, the scan engine returns to the service > > channel automatically. While it *might* work okay to > change or reset > > that channel, it is not necessary, and might be asking for trouble. > > Well, in the patch right now the channel the user sets will > be completely ignored because the scan_finished thing doesn't > reconfigure the hardware as it should. > > Since the user has an expectation that the working channel is > changed after setting it with the ioctl, the code should make > sure. Since hw scanning is mostly transparent to mac80211, > the ioctl should imho be passed to the driver right away. If > there's a problem with setting it to the hardware directly, > the driver can cache it for until the firmware scan finished, > but I don't think we should do that in mac80211. It has to be > done somewhere though and just ignoring the setting is wrong. I see ... thanks, I didn't quite understand the context. Agreed, if the user says to do something, we should not throw it on the floor. -- Ben -- > > johannes > - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
