On Tue, 2007-11-20 at 01:17 +0100, Johannes Berg wrote: > Once a while a driver will give us a bogus MAC address. This can be > remedied by the user by setting the MAC address on the wlanX interface, > but unfortunately one cannot change the address of the wmasterX > interface which results in wlanX going up but wmasterX refusing to. This > is pretty bad. This patch forces wmasterX to have a valid MAC address. > The actual address doesn't matter at all. > > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > --- > Or should we hardcode one and always use that instead of the device > address? Hmm. Considering this. udev has trouble with devices with the same MAC address, maybe we *should* hardcode a different one? That'd also stop people from using the master device's MAC address as the "eeprom MAC" that should be gotten from sysfs instead. It's bound to happen ;) > --- everything.orig/net/mac80211/ieee80211.c 2007-11-20 00:25:03.008708602 +0100 > +++ everything/net/mac80211/ieee80211.c 2007-11-20 00:27:09.278700356 +0100 > @@ -1286,6 +1286,8 @@ int ieee80211_register_hw(struct ieee802 > goto fail_dev; > > memcpy(local->mdev->dev_addr, local->hw.wiphy->perm_addr, ETH_ALEN); > + if (!is_valid_ether_addr(local->mdev->dev_addr)) > + random_ether_addr(local->mdev->dev_addr); > SET_NETDEV_DEV(local->mdev, wiphy_dev(local->hw.wiphy)); > > result = register_netdevice(local->mdev); > > > - > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Attachment:
signature.asc
Description: This is a digitally signed message part
