On Fri, 2007-11-16 at 15:17 +0200, Kalle Valo wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > > >> +#define AR5K_INFO(_sc, _fmt, ...) \ > >> + printk(KERN_INFO "ath5k %s: " _fmt, wiphy_name((_sc)->hw->wiphy), ##__VA_ARGS__) > > > > Eww. Can't you make them static inlines? > > Wasn't it so that a inline function with va_args is not possible? Hmm. That might be true. How about just using dev_dbg? Not that I really ever need to look into ath5k (hopefully!), but the code just struck me as not very nice. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
