I recently experienced unexplainable behaviour with the b43
driver when I had broken firmware uploaded. The cause may have
been that promisc mode was not correctly enabled or disabled
and this bug may have been the cause.
Note how the values are compared later in the function so
just doing the & will result in the wrong thing being
compared and the test being false almost always.
Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
---
John, please push for 2.6.24. As this bug was introduced with the filter
flags changes, it's not applicable to .23.
net/mac80211/ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- everything.orig/net/mac80211/ieee80211.c 2007-11-16 01:44:14.211949434 +0100
+++ everything/net/mac80211/ieee80211.c 2007-11-16 01:44:22.401940754 +0100
@@ -366,8 +366,8 @@ static void ieee80211_set_multicast_list
allmulti = !!(dev->flags & IFF_ALLMULTI);
promisc = !!(dev->flags & IFF_PROMISC);
- sdata_allmulti = sdata->flags & IEEE80211_SDATA_ALLMULTI;
- sdata_promisc = sdata->flags & IEEE80211_SDATA_PROMISC;
+ sdata_allmulti = !!(sdata->flags & IEEE80211_SDATA_ALLMULTI);
+ sdata_promisc = !!(sdata->flags & IEEE80211_SDATA_PROMISC);
if (allmulti != sdata_allmulti) {
if (dev->flags & IFF_ALLMULTI)
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
