On Nov 15, 2007 6:59 PM, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote:
> 2007/11/15, Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
>
> > On Nov 14, 2007 11:14 AM, Nick Kossifidis <mick@xxxxxxxxxxx> wrote:
> > > *Fix device info code
> > >
> > > Changes-licensed-under: 3-clause-BSD
> > > Signed-Off-by: Nick Kossifidis <mickflemm@xxxxxxxxx>
> > >
> > > ---
> > > diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> > > index 4c4837f..0d0e060 100644
> > > --- a/drivers/net/wireless/ath5k/base.c
> > > +++ b/drivers/net/wireless/ath5k/base.c
> > > @@ -570,22 +570,40 @@ ath5k_pci_probe(struct pci_dev *pdev,
> > > if (ret)
> > > goto err_ah;
> > >
> > > - dev_info(&pdev->dev, "Atheros AR%s chip found: MAC 0x%x, PHY: 0x%x\n",
> > > + dev_info(&pdev->dev, "Atheros AR%s chip found (MAC: 0x%x, PHY: 0x%x)\n",
> > > ath5k_chip_name(AR5K_VERSION_VER,sc->ah->ah_mac_srev),
> > > sc->ah->ah_mac_srev,
> > > sc->ah->ah_phy_revision);
> > >
> > > - if(sc->ah->ah_radio_5ghz_revision && !sc->ah->ah_radio_2ghz_revision){
> > > - dev_info(&pdev->dev, "RF%s radio found (0x%x)\n",
> > > - ath5k_chip_name(AR5K_VERSION_RAD,sc->ah->ah_radio_5ghz_revision),
> > > - sc->ah->ah_radio_5ghz_revision);
> > > - } else if(sc->ah->ah_radio_5ghz_revision && sc->ah->ah_radio_2ghz_revision){
> > > - dev_info(&pdev->dev, "RF%s 5GHz radio found (0x%x)\n",
> > > - ath5k_chip_name(AR5K_VERSION_RAD,sc->ah->ah_radio_5ghz_revision),
> > > - sc->ah->ah_radio_5ghz_revision);
> > > - dev_info(&pdev->dev, "RF%s 2GHz radio found (0x%x)\n",
> > > - ath5k_chip_name(AR5K_VERSION_RAD,sc->ah->ah_radio_2ghz_revision),
> > > - sc->ah->ah_radio_2ghz_revision);
> > > + if(!sc->ah->ah_single_chip){
> >
> > I'm a bit confused here you check for not single chip
> >
> Single chip solution (ah_single_chip) means PHY chip integrated with
> MAC, we don't need to print radio info for them because there are no
> separate radio chips.
Ah, thanks for clarifying this. Hm, we should rename ah_single_chip
then being that we use "single chip" very differently below. That can
wait though.
> > > + /* Single chip radio (!RF5111) */
> > > + if(sc->ah->ah_radio_5ghz_revision && !sc->ah->ah_radio_2ghz_revision) {
> >
> > And here you say it is. Can you elaborate a bit on this?
> >
> This is single chip radio, a PHY that both 5HGz/2GHz radios are in one
> chip (only 5111 is a dual chip radio with 5111 for 5GHz and 2111 for
> 2GHz).
>
Thanks for clarifying this.
Acked-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxxxx>
Luis
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
