Search Linux Wireless

Re: [RFC/T] b43: Implement the BCM94311MCG rev 02 card with a rev 13 802.11 core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 15 November 2007 16:02:48 Larry Finger wrote:
> >> @@ -695,11 +687,12 @@ static int dmacontroller_setup(struct b4
> >>  			b43_dma_write(ring, B43_DMA32_RXRING,
> >>  				      (ringbase & ~SSB_DMA_TRANSLATION_MASK)
> >>  				      | trans);
> >> -			b43_dma_write(ring, B43_DMA32_RXINDEX, 200);
> >> +			b43_dma_write(ring, B43_DMA32_RXINDEX, ring->nr_slots *
> >> +				      sizeof(struct b43_dmadesc32));
> > 
> > I'm not sure why you do this change.
> 
> It took me a while to figure out where the magic number of 200 came from, and what I needed for the
> 64-bit case. In fact I think the 200 is a bug and should be 0x200. To me, this change makes it clearer.

The 200 is just a random number.
I think we don't really care what the value is. (Except zero, which doesn't
work on some devices).

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux