Search Linux Wireless

RE: [PATCH 06/14] mac80211: adding 802.11n essential A-MSDURxcapability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > I'm not sure I'd like to see such a thing. One thing I'm generally
> > unhappy with here is how the handlers are in a list but there isn't a
> > point in adding/removing any. Also, I'm not convinced that what you're
> > saying will actually work because the handlers expect 802.11 frames so
> > you'd have to make 802.11 frames out of the 802.3 frames you get...
> 
> True, it is a drawback, as I'll have to create 802.11 frames instead of
> 802.3 (with important data duplicated into all of them), but then I'll
> just call  ieee80211_invoke_rx_handlers with ieee80211_rx_handler
> pointed to
> local->rx_handlers[ieee80211_rx_h_802_1x_pae]. Then I won't have to
> change any existing handler except of my new ieee80211_rx_h_amsdu
> Do you think this approach makes sense?

I'm not convinced. That seems fairly ad-hoc and likely to break in the
future because only parts of the 802.11 header can be reconstructed.

> Do you mean ieee80211_rx_h_decrypt? 
> If yes, I see it uses 3 different decrypt schemes. Here I have one
> scheme reaping it self over and over.

Yeah, this used to have four or five different RX handlers.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux