> Well, aggregation handling is the next step if these patches are > acceptable... :) :) > You are right, A-MPDU is really in the bottom of the data plane > architecture, so in most cases _creating_ it will be an HW feature, > while A-MSDU should be implemented in a much higher level place in the > flow. > Two reasons why I placed A-MPDU handling in the mac80211: > - A-MPDU demands a "session" level management (add BACK, del BACK, BAR), > which looks to me more mac80211 oriented > - A-MPDU extends the "Access Category" of 11e into "Traffic Identifier" > (TID) to give finer granularity of frames priority. As mac80211 already > handles prioritization in wme.c, it looked like a good starting point. Ok, thanks for the clarification. That means that when you implement a-mpdu aggregation handling you'll have some way to tell the hardware to aggregate the next N frames? > >> + /* TODO - add here aggregation support */ > > > I think that comment is misleading. We don't add aggregation support > > here but rather when adding it we must change this code, but anyway. > > Don't bother. > > I can remove that, just a reference for development convenience. Nah, it's fine. Or maybe rephrase it a bit if you care. > > Btw. I'd like to remove code from ieee80211_sta.c rather than add this > > much. Do you see any way to partition your code differently? The > > ieee80211_sta.c file is a huge file and barely understandable when you > > just read it... I was at one time working on extracting the scan code > > out from it and keep only MLME stuff in there. My goal was to be able > to > > As mentioned above - one can treat A-MPDU session as a kind of MLME, so > this is a rather interesting point. Currently I'll keep the code there, > and if you see it burdens ieee80211_sta.c just tell me. Ok, it's fine, I'll look at it a bit more in depth at some other time. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
