Search Linux Wireless

Re: [RFC] b43: fix multi MAC address hardware crypto support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +static void b43_op_sta_notify(struct ieee80211_hw *hw, int if_id,
> +			      enum sta_notify_cmd cmd, const u8 *addr)
> +{
> +	struct b43_wl *wl = hw_to_b43_wl(hw);
> +	struct b43_wldev *dev;
> +	unsigned long flags;
> +	int sta_keys_start, i;
> +	DECLARE_MAC_BUF(mbuf);
> +
> +	/*
> +	 * NB: This function relies (for correctness) on the fact that
> +	 *     sta_notify() is always called before set_key() for any
> +	 *     given station.
> +	 */
> +
> +	/*
> +	 * For now, don't add back a STA to the RX key matching
> +	 * when it is removed from the second virtual interface.
> +	 */
> +	if (cmd != STA_NOTIFY_ADD)
> +		return;
> +
> +	mutex_lock(&wl->mutex);

Hm. this is atomic, can't lock the mutex.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux