On 10/31/07, Dan Williams <dcbw@xxxxxxxxxx> wrote: > I'm not sure where this would go (and therefore don't know if you've > done it or not), but we need to make sure that mesh devices have some > sort of differentiating attribute in sysfs. For example, the mac80211 > master device has a "type" of 803 (or something like that) and and the > STA device has a type of 1. That probably can't be used here, because > mesh devices are the same as STA devices from the perspective of an > application trying to push data to it. But something else needs to be > there. More comments below... I do not know either what would be the best place (Johannes?) but I am going to implement specific mesh statistics in sysfs so you could use that or I could add a specific mesh_iface flag in sysfs. > > + IEEE80211_MESH > > Just "MESH" doesn't seem quite descriptive enough here... what exactly > is this state supposed to mean, that the interface is currently in a > mesh? Right. As soon as the interface comes up, it is in a mesh, even if it is the only node. The mesh id will be the one specified or the wildcard zero-length mesh id if none was specified. There is no association or authentication process (actually there is, but in a per-link basis), so only one mesh state is required. If you prefer MESH_ON, MESH_ACTIVE or something like that I do not mind changing it. > /proc/net/wireless was a colossal mistake from a userspace perspective > since people started screenscraping it, and that's almost _always_ the > wrong wrong wrong thing to do. Ok, got the message, getting rid of /proc/net/mesh, will go the nl80211s/sysfs way. > the } and else should be on the same line. I think 'checkpatch.pl' > should catch this, its in the kernel sources in scripts/. Thanks for the tip! -- Luis Carlos Cobo Rus GnuPG ID: 44019B60 cozybit Inc. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
